Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.8 #32

Merged
merged 8 commits into from
May 28, 2024
Merged

Support ghc 9.8 #32

merged 8 commits into from
May 28, 2024

Conversation

alexfmpe
Copy link
Contributor

@alexfmpe alexfmpe commented Apr 10, 2024

On top of #31 but done as a separate PR as the dependent-sum-template lower bound is increased, which I guess can count as a breaking change?

EDIT: Oh probably not, since it's only a bound on the executable?
I tried only increasing the upper bound but it keeps picking up 0.1 unless I increase the lower one.
For the record, here's the error

Building library for dependent-sum-template-0.1.1.1..
[1 of 3] Compiling Data.Dependent.Sum.TH.Internal ( src/Data/Dependent/Sum/TH/Internal.hs, dist/build/Data/Dependent/Sum/TH/Internal.o, dist/build/Data/Dependent/Sum/TH/Internal.dyn_o )

src/Data/Dependent/Sum/TH/Internal.hs:40:22: error: [GHC-83865]
    • Couldn't match type ‘BndrVis’ with ‘()’
      Expected: [TyVarBndrUnit]
        Actual: [TyVarBndr BndrVis]
    • In the first argument of ‘f’, namely ‘bndrs’
      In a stmt of a 'do' block: dec <- f bndrs cons
      In the expression:
        do dec <- f bndrs cons
           return [InstanceD overlaps cxt classHead [...]]
   |
40 |             dec <- f bndrs cons
   |                      ^^^^^

src/Data/Dependent/Sum/TH/Internal.hs:46:17: error: [GHC-83865]
    • Couldn't match type ‘BndrVis’ with ‘()’
      Expected: [TyVarBndrUnit]
        Actual: [TyVarBndr BndrVis]
    • In the first argument of ‘f’, namely ‘bndrs’
      In the expression: f bndrs cons
      In an equation for ‘dec’: dec = f bndrs cons
   |
46 |         dec = f bndrs cons
   |                 ^^^^^
Error: cabal: Failed to build dependent-sum-template-0.1.1.1 (which is
required by exe:readme from aeson-gadt-th-0.2.5.1). See the build log above
for details.

@alexfmpe alexfmpe changed the title Bump ghc 9.8 Support ghc 9.8 Apr 11, 2024
@alexfmpe
Copy link
Contributor Author

Think this also needs a release of
obsidiansystems/dependent-sum-template@dfaf678

@ali-abrar ali-abrar merged commit 0cbfbee into obsidiansystems:develop May 28, 2024
13 checks passed
let pkgs = import ./nixpkgs/23.11 {};
hpkgs = {
overrides = self: super: {
dependent-sum-template = self.callHackageDirect {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably. but i already merged ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIght, I meant it more as a FYI for any other repos with a big blob of release.nix that can now be aggressively pruned down

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the PRs btw

@ali-abrar
Copy link
Member

released to hackage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants